Skip to content

test: add unit tests for pet-windows-registry crate (Fixes #389)#442

Open
karthiknadig wants to merge 1 commit into
mainfrom
test/issue-389-windows-registry
Open

test: add unit tests for pet-windows-registry crate (Fixes #389)#442
karthiknadig wants to merge 1 commit into
mainfrom
test/issue-389-windows-registry

Conversation

@karthiknadig
Copy link
Copy Markdown
Member

Add 4 new unit tests to pet-windows-registry (10 total, up from 6):

  • try_from returns None for plain env without cache
  • Sync from source with None cache clears shared state
  • Sync is idempotent (double-sync produces same result)
  • GlobalFiltered with Conda kind triggers sync

Fixes #389

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Performance Report (Linux) ✅

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 1ms 1ms 1ms 0ms 0%
Full Refresh 53ms 339ms 56ms -3ms 0%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Test Coverage Report (Linux)

Metric Value
Current Coverage 79.6%
Base Branch Coverage 78.1%
Delta 1.5% ✅

Coverage increased! Great work!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Performance Report (macOS)

Metric PR (P50) PR (P95) Baseline (P50) Delta
Server Startup 59ms 555ms 93ms -34ms
Full Refresh 124ms 30658ms 179ms -55ms

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Performance Report (Windows) ➖

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 8ms 11ms 7ms 1ms 14.3%
Full Refresh 118ms 1558ms 92ms 26ms 28.3%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Test Coverage Report (Windows)

Metric Value
Current Coverage 76.61%
Base Branch Coverage 76.15%
Delta 0.46% ✅

Coverage increased! Great work!

@karthiknadig karthiknadig force-pushed the test/issue-389-windows-registry branch from 1c2c403 to 34cc095 Compare April 23, 2026 15:48
@karthiknadig karthiknadig marked this pull request as ready for review April 23, 2026 16:32
eleanorjboyd
eleanorjboyd previously approved these changes Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coverage: ranked plan to move workspace coverage toward 90%

2 participants